feat(Data/neo4jDatabases): add Neo4j resource type and Kubernetes recipe #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Beenham <[email protected]>
Author
|
@Reshrahim new PR |
Reshrahim
requested changes
Oct 7, 2025
Contributor
Reshrahim
left a comment
Reshrahim
left a comment
There was a problem hiding this comment.
Thanks for the contribution @superbeeny. I tested the Recipe deployment and it seems to be working
Suggested minor changes for consistency across definitions in the repo.
| |------------|-----------|--------------------------------------|-------| | ||
| | Kubernetes | Bicep | `kubernetes-neo4j.bicep` | Alpha | | ||
|
|
||
| ## Recipe Input Properties |
Contributor
There was a problem hiding this comment.
For consistency across definitions, would be good to follow this format for Recipe input and output properties -https://github.com/radius-project/resource-types-contrib/blob/main/Data/mySqlDatabases/README.md
zachcasper
reviewed
Oct 7, 2025
Contributor
zachcasper
left a comment
zachcasper
left a comment
There was a problem hiding this comment.
The resource type definition looks good to me. I did not test the recipe. It's difficult to test without a test application.
Signed-off-by: Nick Beenham <[email protected]>
Signed-off-by: Nick Beenham <[email protected]>
Signed-off-by: Nick Beenham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacement PR #45
Related GitHub Issue:
Testing
Contributor Checklist
rad resource-type showis correctenum: []required: []for every object property (not just the top-level properties)readOnly: true